03727: spiders: Source typo in discrete sound system

- As of 0.139u2, some drivers and options show "16-bit EEPROM set with 8-bit data". Check 4030.
- Haze is calling for mixing issues with *SINGLE* VDP games in toaplan2.c. Check 4044.

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Source: spiders.c ]

Category [?]

Severity [?]

Reproducibility

Date Submitted

Last Update

03727

Misc.

Critical (Game)

Always

2010-02-11 09:15

2010-02-15 18:59

Tester

M.A.S.H.

View Status

Public

Assigned To

M.A.S.H.

Platform

MAME (Self-compiled)

Priority

normal

Resolution

Fixed

Windows XP (32-bit)

Status [?]

Resolved

Driver

spiders.c

Projection

None

Version

0.136u2

ETA

None

Fixed in Version

0.136u4

Build

Normal

Summary

03727: spiders: Source typo in discrete sound system

Description

The discrete sound system was changed in MAME 0.134u1. All Enable input were
be removed from a number of discrete sound modules.
The game Spiders (1981) has since this version a bad fire sound output. I compare
the MAME 0.134 and 0.134u1 sources and found in the discrete sound files that
all _ENABLE modules was removed like:

#define DST_LOOKUP_TABLE__ENABLE DISCRETE_INPUT(0)
#define DST_LOOKUP_TABLE__IN DISCRETE_INPUT(1)
#define DST_LOOKUP_TABLE__SIZE DISCRETE_INPUT(2)

to

#define DST_LOOKUP_TABLE__IN DISCRETE_INPUT(0)
#define DST_LOOKUP_TABLE__SIZE DISCRETE_INPUT(1)

and the INPUT files were renumbered. But not in sound\disc_mth.c.
So if you changed in emu\sound\disc_mth.c lines 1624-1626 from

#define DST_ASWITCH__CTRL DISCRETE_INPUT(1)
#define DST_ASWITCH__IN DISCRETE_INPUT(2)
#define DST_ASWITCH__THRESHOLD DISCRETE_INPUT(3)

to

#define DST_ASWITCH__CTRL DISCRETE_INPUT(0)
#define DST_ASWITCH__IN DISCRETE_INPUT(1)
#define DST_ASWITCH__THRESHOLD DISCRETE_INPUT(2)

the fire sound in Spiders sound like the old one in MAME 0.134 again.

Steps To Reproduce

Additional Information

Flags

Regression Version

0.134u1

Affected Sets

spiders

Old BugID

Attached Files

Relationships

Notes
(05709) Tafoid (Administrator) 2010-02-11 23:48	Well, here is the thing. That game had an implementation which was believed correct in 0.134. Things were changed in 0.134u1 and it was flagged, known to be inaccurate (not 100%) sound. Unless we can get some original pcb recordings, there isn't a lot I can do there. Reverting sometimes is the way to fix things, but often not. I'll acknowledge with the hope some pcb audio shows up.